[pickers] Fix aria-labelledby assignment to dialog
#7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
accessibility
These are the results for the performance tests:
|
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/PickersLayout/PickersLayout.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
packages/x-date-pickers-pro/src/internal/hooks/useMobileRangePicker/useMobileRangePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Lukas <[email protected]>
LukasTy
changed the title
aria-labelledby assignmentaria-labelledby assignment to dialog
alexfauquette
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5632
Explicitly pass
aria-labelledbyreferencing toolbar or text field label if toolbar is hiddenP.S. Desktop range pickers currently don't need similar changes, because they only support interaction through input element—the dialog is not being focused.